imx_watchdog: always set minimal timeout in reset_cpu
authorAndrey Skvortsov <andrej.skvortzov@gmail.com>
Sun, 20 Dec 2015 18:09:58 +0000 (21:09 +0300)
committerStefano Babic <sbabic@denx.de>
Thu, 7 Jan 2016 16:54:53 +0000 (17:54 +0100)
The problem is that timeout bits in WCR register were leaved unchanged.
So previously set timeout value was applied and therefore 'reset'
command takes any value up to two minutes, depending on previous
watchdog settings, instead of minimal 0.5 seconds.

Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
drivers/watchdog/imx_watchdog.c
include/fsl_wdog.h

index 0d77595..f9f8175 100644 (file)
@@ -43,7 +43,7 @@ void reset_cpu(ulong addr)
 {
        struct watchdog_regs *wdog = (struct watchdog_regs *)WDOG1_BASE_ADDR;
 
-       clrsetbits_le16(&wdog->wcr, 0, WCR_WDE);
+       clrsetbits_le16(&wdog->wcr, WCR_WT_MSK, WCR_WDE);
 
        writew(0x5555, &wdog->wsr);
        writew(0xaaaa, &wdog->wsr);     /* load minimum 1/2 second timeout */
index d15a70c..f698d4d 100644 (file)
@@ -16,3 +16,4 @@ struct watchdog_regs {
 #define WCR_WDT                0x08
 #define WCR_SRS                0x10
 #define SET_WCR_WT(x)  (x << 8)
+#define WCR_WT_MSK     SET_WCR_WT(0xFF)