media: sunxi-cir: Clean up dead register writes
authorSamuel Holland <samuel@sholland.org>
Mon, 18 Jan 2021 06:00:45 +0000 (07:00 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 27 Jan 2021 07:25:36 +0000 (08:25 +0100)
The register writes during driver removal occur after the device is
already put back in reset, so they never had any effect.

Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/rc/sunxi-cir.c

index 8555c77..0a7f7ea 100644 (file)
@@ -342,22 +342,12 @@ exit_reset_assert:
 
 static int sunxi_ir_remove(struct platform_device *pdev)
 {
-       unsigned long flags;
        struct sunxi_ir *ir = platform_get_drvdata(pdev);
 
        clk_disable_unprepare(ir->clk);
        clk_disable_unprepare(ir->apb_clk);
        reset_control_assert(ir->rst);
 
-       spin_lock_irqsave(&ir->ir_lock, flags);
-       /* disable IR IRQ */
-       writel(0, ir->base + SUNXI_IR_RXINT_REG);
-       /* clear All Rx Interrupt Status */
-       writel(REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG);
-       /* disable IR */
-       writel(0, ir->base + SUNXI_IR_CTL_REG);
-       spin_unlock_irqrestore(&ir->ir_lock, flags);
-
        rc_unregister_device(ir->rc);
        return 0;
 }