staging: wilc1000: change return type to 'void' tcp ack filter functions
authorAjay Singh <ajay.kathat@microchip.com>
Tue, 25 Sep 2018 06:23:23 +0000 (11:53 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Sep 2018 18:53:56 +0000 (20:53 +0200)
Use 'void' return type for below functions as they always return '0' and
their return value is not used by caller.
add_tcp_pending_ack()
update_tcp_session()
add_tcp_pending_ack()

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/wilc_wlan.c

index 8057db9..66ce29d 100644 (file)
@@ -91,8 +91,8 @@ static void wilc_wlan_txq_add_to_head(struct wilc_vif *vif,
 
 #define NOT_TCP_ACK                    (-1)
 
-static inline int add_tcp_session(struct wilc_vif *vif, u32 src_prt,
-                                 u32 dst_prt, u32 seq)
+static inline void add_tcp_session(struct wilc_vif *vif, u32 src_prt,
+                                  u32 dst_prt, u32 seq)
 {
        struct tcp_ack_filter *f = &vif->ack_filter;
 
@@ -103,22 +103,20 @@ static inline int add_tcp_session(struct wilc_vif *vif, u32 src_prt,
                f->ack_session_info[f->tcp_session].dst_port = dst_prt;
                f->tcp_session++;
        }
-       return 0;
 }
 
-static inline int update_tcp_session(struct wilc_vif *vif, u32 index, u32 ack)
+static inline void update_tcp_session(struct wilc_vif *vif, u32 index, u32 ack)
 {
        struct tcp_ack_filter *f = &vif->ack_filter;
 
        if (index < 2 * MAX_TCP_SESSION &&
            ack > f->ack_session_info[index].bigger_ack_num)
                f->ack_session_info[index].bigger_ack_num = ack;
-       return 0;
 }
 
-static inline int add_tcp_pending_ack(struct wilc_vif *vif, u32 ack,
-                                     u32 session_index,
-                                     struct txq_entry_t *txqe)
+static inline void add_tcp_pending_ack(struct wilc_vif *vif, u32 ack,
+                                      u32 session_index,
+                                      struct txq_entry_t *txqe)
 {
        struct tcp_ack_filter *f = &vif->ack_filter;
        u32 i = f->pending_base + f->pending_acks_idx;
@@ -130,7 +128,6 @@ static inline int add_tcp_pending_ack(struct wilc_vif *vif, u32 ack,
                txqe->ack_idx = i;
                f->pending_acks_idx++;
        }
-       return 0;
 }
 
 static inline void tcp_process(struct net_device *dev, struct txq_entry_t *tqe)