mtd: rawnand: qcom: Unmap the right resource upon probe failure
authorBibek Kumar Patro <quic_bibekkum@quicinc.com>
Wed, 13 Sep 2023 07:07:02 +0000 (12:37 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Oct 2023 10:03:13 +0000 (12:03 +0200)
commit 5279f4a9eed3ee7d222b76511ea7a22c89e7eefd upstream.

We currently provide the physical address of the DMA region
rather than the output of dma_map_resource() which is obviously wrong.

Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
Cc: stable@vger.kernel.org
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20230913070702.12707-1-quic_bibekkum@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mtd/nand/raw/qcom_nandc.c

index 198a447..fbf36cb 100644 (file)
@@ -3310,7 +3310,7 @@ err_nandc_alloc:
 err_aon_clk:
        clk_disable_unprepare(nandc->core_clk);
 err_core_clk:
-       dma_unmap_resource(dev, res->start, resource_size(res),
+       dma_unmap_resource(dev, nandc->base_dma, resource_size(res),
                           DMA_BIDIRECTIONAL, 0);
        return ret;
 }