net: mvpp2: Unshadow error code of device_property_read_u32()
authorAndy Shevchenko <andy.shevchenko@gmail.com>
Mon, 10 May 2021 09:58:08 +0000 (12:58 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 10 May 2021 21:47:23 +0000 (14:47 -0700)
device_property_read_u32() may return different error codes.
Propagate it to the caller.

Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

index b6b7ba8..9f464e4 100644 (file)
@@ -7458,10 +7458,12 @@ static int mvpp2_probe(struct platform_device *pdev)
 
                /* Get system's tclk rate */
                priv->tclk = clk_get_rate(priv->pp_clk);
-       } else if (device_property_read_u32(&pdev->dev, "clock-frequency",
-                                           &priv->tclk)) {
-               dev_err(&pdev->dev, "missing clock-frequency value\n");
-               return -EINVAL;
+       } else {
+               err = device_property_read_u32(&pdev->dev, "clock-frequency", &priv->tclk);
+               if (err) {
+                       dev_err(&pdev->dev, "missing clock-frequency value\n");
+                       return err;
+               }
        }
 
        if (priv->hw_version >= MVPP22) {