webrtc: advertise support for transport-cc rtcp-fb by default
authorMatthew Waters <matthew@centricular.com>
Thu, 29 Apr 2021 11:12:42 +0000 (21:12 +1000)
committerMatthew Waters <matthew@centricular.com>
Thu, 29 Apr 2021 12:01:54 +0000 (22:01 +1000)
Still requires explicit enabling by the application through the header
extension on all the relevant payloaders.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2207>

ext/webrtc/gstwebrtcbin.c

index a13bed2..cde8a24 100644 (file)
@@ -1590,9 +1590,8 @@ _add_supported_attributes_to_caps (GstWebRTCBin * webrtc,
 
     if (!gst_structure_has_field (s, "rtcp-fb-nack-pli"))
       gst_structure_set (s, "rtcp-fb-nack-pli", G_TYPE_BOOLEAN, TRUE, NULL);
-    /* FIXME: is this needed? */
-    /*if (!gst_structure_has_field (s, "rtcp-fb-transport-cc"))
-       gst_structure_set (s, "rtcp-fb-nack-pli", G_TYPE_BOOLEAN, TRUE, NULL); */
+    if (!gst_structure_has_field (s, "rtcp-fb-transport-cc"))
+      gst_structure_set (s, "rtcp-fb-transport-cc", G_TYPE_BOOLEAN, TRUE, NULL);
 
     /* FIXME: codec-specific parameters? */
   }