RDMA/vmw_pvrdma: Use zeroing memory allocator than allocator/memset
authorHimanshu Jha <himanshujha199640@gmail.com>
Sun, 31 Dec 2017 12:29:00 +0000 (17:59 +0530)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 2 Jan 2018 18:20:13 +0000 (11:20 -0700)
Use dma_zalloc_coherent for allocating zeroed
memory and remove unnecessary memset function.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.

Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c

index 939ac2f..d650a9f 100644 (file)
@@ -882,8 +882,8 @@ static int pvrdma_pci_probe(struct pci_dev *pdev,
        dev_info(&pdev->dev, "device version %d, driver version %d\n",
                 dev->dsr_version, PVRDMA_VERSION);
 
-       dev->dsr = dma_alloc_coherent(&pdev->dev, sizeof(*dev->dsr),
-                                     &dev->dsrbase, GFP_KERNEL);
+       dev->dsr = dma_zalloc_coherent(&pdev->dev, sizeof(*dev->dsr),
+                                      &dev->dsrbase, GFP_KERNEL);
        if (!dev->dsr) {
                dev_err(&pdev->dev, "failed to allocate shared region\n");
                ret = -ENOMEM;
@@ -891,7 +891,6 @@ static int pvrdma_pci_probe(struct pci_dev *pdev,
        }
 
        /* Setup the shared region */
-       memset(dev->dsr, 0, sizeof(*dev->dsr));
        dev->dsr->driver_version = PVRDMA_VERSION;
        dev->dsr->gos_info.gos_bits = sizeof(void *) == 4 ?
                PVRDMA_GOS_BITS_32 :