crypto: hisilicon/hpre - change return type of hpre_cluster_inqry_write()
authorWeili Qian <qianweili@huawei.com>
Sat, 13 Aug 2022 10:34:21 +0000 (18:34 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 19 Aug 2022 10:39:38 +0000 (18:39 +0800)
hpre_cluster_inqry_write() always returns 0. So change the type
of hpre_cluster_inqry_write() to void.

Signed-off-by: Weili Qian <qianweili@huawei.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/hisilicon/hpre/hpre_main.c

index 9d529df..8e0e87c 100644 (file)
@@ -708,7 +708,7 @@ static u32 hpre_cluster_inqry_read(struct hpre_debugfs_file *file)
        return readl(qm->io_base + offset + HPRE_CLSTR_ADDR_INQRY_RSLT);
 }
 
-static int hpre_cluster_inqry_write(struct hpre_debugfs_file *file, u32 val)
+static void hpre_cluster_inqry_write(struct hpre_debugfs_file *file, u32 val)
 {
        struct hisi_qm *qm = hpre_file_to_qm(file);
        int cluster_index = file->index - HPRE_CLUSTER_CTRL;
@@ -716,8 +716,6 @@ static int hpre_cluster_inqry_write(struct hpre_debugfs_file *file, u32 val)
                               HPRE_CLSTR_ADDR_INTRVL;
 
        writel(val, qm->io_base + offset + HPRE_CLUSTER_INQURY);
-
-       return 0;
 }
 
 static ssize_t hpre_ctrl_debug_read(struct file *filp, char __user *buf,
@@ -792,9 +790,7 @@ static ssize_t hpre_ctrl_debug_write(struct file *filp, const char __user *buf,
                        goto err_input;
                break;
        case HPRE_CLUSTER_CTRL:
-               ret = hpre_cluster_inqry_write(file, val);
-               if (ret)
-                       goto err_input;
+               hpre_cluster_inqry_write(file, val);
                break;
        default:
                ret = -EINVAL;