mikmod_reader: Possible null pointer dereference:

gst_reader variable is being used before actually checking if it
allocated properly

https://bugzilla.gnome.org/show_bug.cgi?id=751306

diff --git a/ext/mikmod/mikmod_reader.c b/ext/mikmod/mikmod_reader.c
index f8e83de177096b51a55d0ac1a0eeaaa4612b0c15..f1c2a4356cf44178b2cd265039c2f040e3ab2b56 100644 (file)
--- a/ext/mikmod/mikmod_reader.c
+++ b/ext/mikmod/mikmod_reader.c
@@ -90,10 +90,12 @@ GST_READER_new (GstMikMod * mik)
   GST_READER *gst_reader;
 
   gst_reader = (GST_READER *) g_malloc (sizeof (GST_READER));
-  gst_reader->offset = 0;
-  gst_reader->eof = 0;
-  gst_reader->mik = mik;
+
   if (gst_reader) {
+    gst_reader->offset = 0;
+    gst_reader->eof = 0;
+    gst_reader->mik = mik;
+
     gst_reader->core.Eof = &GST_READER_Eof;
     gst_reader->core.Read = &GST_READER_Read;
     gst_reader->core.Get = &GST_READER_Get;