PCI: ibmphp: Make read-only arrays static
authorColin Ian King <colin.i.king@gmail.com>
Tue, 27 Jun 2023 12:56:12 +0000 (13:56 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 18 Jul 2023 21:52:41 +0000 (16:52 -0500)
Don't populate the arrays on the stack; instead make them static const.

Link: https://lore.kernel.org/r/20230627125612.724764-1-colin.i.king@gmail.com
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/hotplug/ibmphp_pci.c

index 754c3f23282e34b04d3865ea3f1e18ce38e3a491..50038e5f9ca4045c91cea42a9c08124ba7039550 100644 (file)
@@ -329,7 +329,7 @@ error:
 static int configure_device(struct pci_func *func)
 {
        u32 bar[6];
-       u32 address[] = {
+       static const u32 address[] = {
                PCI_BASE_ADDRESS_0,
                PCI_BASE_ADDRESS_1,
                PCI_BASE_ADDRESS_2,
@@ -564,7 +564,7 @@ static int configure_bridge(struct pci_func **func_passed, u8 slotno)
        struct resource_node *pfmem = NULL;
        struct resource_node *bus_pfmem[2] = {NULL, NULL};
        struct bus_node *bus;
-       u32 address[] = {
+       static const u32 address[] = {
                PCI_BASE_ADDRESS_0,
                PCI_BASE_ADDRESS_1,
                0
@@ -1053,7 +1053,7 @@ static struct res_needed *scan_behind_bridge(struct pci_func *func, u8 busno)
        int howmany = 0;        /*this is to see if there are any devices behind the bridge */
 
        u32 bar[6], class;
-       u32 address[] = {
+       static const u32 address[] = {
                PCI_BASE_ADDRESS_0,
                PCI_BASE_ADDRESS_1,
                PCI_BASE_ADDRESS_2,
@@ -1182,7 +1182,7 @@ static struct res_needed *scan_behind_bridge(struct pci_func *func, u8 busno)
 static int unconfigure_boot_device(u8 busno, u8 device, u8 function)
 {
        u32 start_address;
-       u32 address[] = {
+       static const u32 address[] = {
                PCI_BASE_ADDRESS_0,
                PCI_BASE_ADDRESS_1,
                PCI_BASE_ADDRESS_2,
@@ -1310,7 +1310,7 @@ static int unconfigure_boot_bridge(u8 busno, u8 device, u8 function)
        struct resource_node *mem = NULL;
        struct resource_node *pfmem = NULL;
        struct bus_node *bus;
-       u32 address[] = {
+       static const u32 address[] = {
                PCI_BASE_ADDRESS_0,
                PCI_BASE_ADDRESS_1,
                0