drm/vc4: dpi: Remove unnecessary drm_of_panel_bridge_remove call

Since we have a managed call to create our panel_bridge instance, the call
to drm_of_panel_bridge_remove() at unbind is both redundant and dangerous
since it might lead to a use-after-free.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220711173939.1132294-28-maxime@cerno.tech

diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c
index 7028a78..f18b05c 100644 (file)
--- a/drivers/gpu/drm/vc4/vc4_dpi.c
+++ b/drivers/gpu/drm/vc4/vc4_dpi.c
@@ -329,8 +329,6 @@ static void vc4_dpi_unbind(struct device *dev, struct device *master,
 {
        struct vc4_dpi *dpi = dev_get_drvdata(dev);
 
-       drm_of_panel_bridge_remove(dev->of_node, 0, 0);
-
        drm_encoder_cleanup(&dpi->encoder.base);
 
        clk_disable_unprepare(dpi->core_clock);