smsc911x: Add check for ioremap_nocache() return code
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Wed, 12 Jul 2017 20:58:56 +0000 (23:58 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Jul 2017 21:35:43 +0000 (14:35 -0700)
There is no check for return code of smsc911x_drv_probe()
in smsc911x_drv_probe(). The patch adds one.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/smsc/smsc911x.c

index ea1bbc3..0b6a39b 100644 (file)
@@ -2467,6 +2467,10 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
        pdata = netdev_priv(dev);
        dev->irq = irq;
        pdata->ioaddr = ioremap_nocache(res->start, res_size);
+       if (!pdata->ioaddr) {
+               retval = -ENOMEM;
+               goto out_ioremap_fail;
+       }
 
        pdata->dev = dev;
        pdata->msg_enable = ((1 << debug) - 1);
@@ -2572,6 +2576,7 @@ out_enable_resources_fail:
        smsc911x_free_resources(pdev);
 out_request_resources_fail:
        iounmap(pdata->ioaddr);
+out_ioremap_fail:
        free_netdev(dev);
 out_release_io_1:
        release_mem_region(res->start, resource_size(res));