[AVR] Fix function pointer address space
authorVlastimil Labsky <vlasta.labsky@gmail.com>
Wed, 1 Apr 2020 08:05:45 +0000 (21:05 +1300)
committerDylan McKay <me@dylanmckay.io>
Wed, 1 Apr 2020 08:08:37 +0000 (21:08 +1300)
Summary:
Function pointers should be created with program address space.
This fixes function pointers on AVR.

Reviewers: dylanmckay

Reviewed By: dylanmckay

Subscribers: Jim, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77119

clang/lib/CodeGen/CodeGenTypes.cpp

index befd80d..29adc2c 100644 (file)
@@ -595,7 +595,11 @@ llvm::Type *CodeGenTypes::ConvertType(QualType T) {
     llvm::Type *PointeeType = ConvertTypeForMem(ETy);
     if (PointeeType->isVoidTy())
       PointeeType = llvm::Type::getInt8Ty(getLLVMContext());
-    unsigned AS = Context.getTargetAddressSpace(ETy);
+
+    unsigned AS = PointeeType->isFunctionTy()
+                      ? getDataLayout().getProgramAddressSpace()
+                      : Context.getTargetAddressSpace(ETy);
+
     ResultType = llvm::PointerType::get(PointeeType, AS);
     break;
   }