xfs: remove unnecessary check of the variable resblks in xfs_symlink
authorKaixu Xia <kaixuxia@tencent.com>
Thu, 23 Apr 2020 04:54:31 +0000 (21:54 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Mon, 4 May 2020 16:03:15 +0000 (09:03 -0700)
Since the "no-allocation" reservations has been removed, the resblks
value should be larger than zero, so remove the unnecessary check.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_symlink.c

index 13fb4b9..9734419 100644 (file)
@@ -243,8 +243,7 @@ xfs_symlink(
         */
        xfs_qm_vop_create_dqattach(tp, ip, udqp, gdqp, pdqp);
 
-       if (resblks)
-               resblks -= XFS_IALLOC_SPACE_RES(mp);
+       resblks -= XFS_IALLOC_SPACE_RES(mp);
        /*
         * If the symlink will fit into the inode, write it inline.
         */
@@ -265,8 +264,7 @@ xfs_symlink(
                if (error)
                        goto out_trans_cancel;
 
-               if (resblks)
-                       resblks -= fs_blocks;
+               resblks -= fs_blocks;
                ip->i_d.di_size = pathlen;
                xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);