Add I-cache flushing to Code::Relocate. No need to call it

from Heap::CopyCode anymore.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@161 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/AUTHORS b/AUTHORS
index fc32ddc..2e85278 100644 (file)
--- a/AUTHORS
+++ b/AUTHORS
@@ -7,3 +7,4 @@ Google Inc.
 
 Rene Rebe <rene@exactcode.de>
 Rafal Krypa <rafal@krypa.net>
+Jay Freeman <saurik@saurik.com>

diff --git a/src/heap.cc b/src/heap.cc
index b04b4c1..395a6b0 100644 (file)
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -1530,9 +1530,6 @@ Object* Heap::CreateCode(const CodeDesc& desc,
 #ifdef DEBUG
   code->Verify();
 #endif
-
-  CPU::FlushICache(code->instruction_start(), code->instruction_size());
-
   return code;
 }
 
@@ -1553,9 +1550,6 @@ Object* Heap::CopyCode(Code* code) {
   // Relocate the copy.
   Code* new_code = Code::cast(result);
   new_code->Relocate(new_addr - old_addr);
-
-  CPU::FlushICache(new_code->instruction_start(), new_code->instruction_size());
-
   return new_code;
 }
 

diff --git a/src/objects.cc b/src/objects.cc
index 2be4ccd..00ee12a 100644 (file)
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4072,6 +4072,7 @@ void Code::Relocate(int delta) {
   for (RelocIterator it(this, RelocInfo::kApplyMask); !it.done(); it.next()) {
     it.rinfo()->apply(delta);
   }
+  CPU::FlushICache(instruction_start(), instruction_size());
 }
 
 
@@ -4112,6 +4113,7 @@ void Code::CopyFrom(const CodeDesc& desc) {
       it.rinfo()->apply(delta);
     }
   }
+  CPU::FlushICache(instruction_start(), instruction_size());
 }