elm view list - just be less obviously a possible bug to coverity
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>
Fri, 8 Jul 2016 02:54:57 +0000 (11:54 +0900)
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>
Fri, 8 Jul 2016 02:54:57 +0000 (11:54 +0900)
CID 1355014 is a false positive, but it's god to not confuse it too
often. clean up.

src/lib/elementary/elm_view_list.c

index 1f7ee28..0833535 100644 (file)
@@ -122,15 +122,16 @@ _item_get_value(View_List_ItemData *idata, const char *part)
      {
          if (vitem->part == NULL)
            {
-              free(vitem);
               unsigned i = eina_list_count(idata->values);
               if (i == 1)
                 {
                    idata->values = eina_list_remove(idata->values, vitem);
                    idata->values = NULL;
+                   free(vitem);
                    break;
                 }
               idata->values = eina_list_remove_list(idata->values, l);
+              free(vitem);
               continue;
            }