net: dsa: remove gratuitous use of dsa_is_{user,dsa,cpu}_port
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 20 Oct 2021 17:49:52 +0000 (20:49 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Oct 2021 11:44:07 +0000 (12:44 +0100)
Find the occurrences of dsa_is_{user,dsa,cpu}_port where a struct
dsa_port *dp was already available in the function scope, and replace
them with the dsa_port_is_{user,dsa,cpu} equivalent function which uses
that dp directly and does not perform another hidden dsa_to_port().

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/port.c

index 3b14c9b..bf67130 100644 (file)
@@ -523,7 +523,7 @@ static bool dsa_port_can_apply_vlan_filtering(struct dsa_port *dp,
         * enter an inconsistent state: deny changing the VLAN awareness state
         * as long as we have 8021q uppers.
         */
-       if (vlan_filtering && dsa_is_user_port(ds, dp->index)) {
+       if (vlan_filtering && dsa_port_is_user(dp)) {
                struct net_device *upper_dev, *slave = dp->slave;
                struct net_device *br = dp->bridge_dev;
                struct list_head *iter;
@@ -1038,7 +1038,7 @@ static void dsa_port_phylink_mac_link_down(struct phylink_config *config,
        struct phy_device *phydev = NULL;
        struct dsa_switch *ds = dp->ds;
 
-       if (dsa_is_user_port(ds, dp->index))
+       if (dsa_port_is_user(dp))
                phydev = dp->slave->phydev;
 
        if (!ds->ops->phylink_mac_link_down) {