wifi: mt76: mt7915: do not check state before configuring implicit beamform
authorHoward Hsu <howard-yh.hsu@mediatek.com>
Thu, 18 Aug 2022 02:44:07 +0000 (10:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 10:34:43 +0000 (12:34 +0200)
[ Upstream commit d2b5bb6dfab29fe32bedefaade88dcd182c03a00 ]

Do not need to check running state before configuring implicit Tx
beamform. It is okay to configure implicit Tx beamform in run time.
Noted that the existing connected stations will be applied for new
configuration only if they reconnected to the interface.

Fixes: 6d6dc980e07d ("mt76: mt7915: add implicit Tx beamforming support")
Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c

index 64048243e34b22312d13be57f21089fcd99a432f..31c1d4bc78dd150cc243d13467a0f76c8f70e4c2 100644 (file)
@@ -12,9 +12,9 @@ mt7915_implicit_txbf_set(void *data, u64 val)
 {
        struct mt7915_dev *dev = data;
 
-       if (test_bit(MT76_STATE_RUNNING, &dev->mphy.state))
-               return -EBUSY;
-
+       /* The existing connected stations shall reconnect to apply
+        * new implicit txbf configuration.
+        */
        dev->ibf = !!val;
 
        return mt7915_mcu_set_txbf(dev, MT_BF_TYPE_UPDATE);