media: platform: Delete vidioc_s_selection ioctl of jpeg dec
authorXia Jiang <xia.jiang@mediatek.com>
Fri, 14 Aug 2020 07:11:49 +0000 (09:11 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 28 Aug 2020 13:30:57 +0000 (15:30 +0200)
JPEG dec does't support setting a compose rectangle, so remove
mtk_jpeg_dec_s_selection().

Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c

index 7e75bc1..a2efe34 100644 (file)
@@ -439,27 +439,6 @@ static int mtk_jpeg_g_selection(struct file *file, void *priv,
        return 0;
 }
 
-static int mtk_jpeg_s_selection(struct file *file, void *priv,
-                               struct v4l2_selection *s)
-{
-       struct mtk_jpeg_ctx *ctx = mtk_jpeg_fh_to_ctx(priv);
-
-       if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
-               return -EINVAL;
-
-       switch (s->target) {
-       case V4L2_SEL_TGT_COMPOSE:
-               s->r.left = 0;
-               s->r.top = 0;
-               s->r.width = ctx->out_q.w;
-               s->r.height = ctx->out_q.h;
-               break;
-       default:
-               return -EINVAL;
-       }
-       return 0;
-}
-
 static const struct v4l2_ioctl_ops mtk_jpeg_ioctl_ops = {
        .vidioc_querycap                = mtk_jpeg_querycap,
        .vidioc_enum_fmt_vid_cap        = mtk_jpeg_enum_fmt_vid_cap,
@@ -473,7 +452,6 @@ static const struct v4l2_ioctl_ops mtk_jpeg_ioctl_ops = {
        .vidioc_qbuf                    = v4l2_m2m_ioctl_qbuf,
        .vidioc_subscribe_event         = mtk_jpeg_subscribe_event,
        .vidioc_g_selection             = mtk_jpeg_g_selection,
-       .vidioc_s_selection             = mtk_jpeg_s_selection,
 
        .vidioc_create_bufs             = v4l2_m2m_ioctl_create_bufs,
        .vidioc_prepare_buf             = v4l2_m2m_ioctl_prepare_buf,