Fix defects detected by static analysis tool

Change-Id: Ia6b0fdf2aa3ca4207a348c1a0ff020285e327d36

diff --git a/src/mmi-cli/mmi-cli.cpp b/src/mmi-cli/mmi-cli.cpp
index 3f512f8d0f1863a324df0034678d03922f64acd0..61d883fe92309c29395c24e5caf4ca92d1b39329 100644 (file)
--- a/src/mmi-cli/mmi-cli.cpp
+++ b/src/mmi-cli/mmi-cli.cpp
@@ -243,6 +243,7 @@ MATCH.COMMAND as MATCHED_CANDIDATE
                 std::cout << "OUTPUT data received : " << std::string(name ? name : "") << std::endl;
             },
             nullptr);
+        mmi_workflow_destroy(workflow);
     }
     void create_instance_from_file(std::string path) {
         if (m_instance) {
@@ -266,6 +267,7 @@ MATCH.COMMAND as MATCHED_CANDIDATE
         mmi_workflow_h workflow;
         mmi_workflow_create_from_script(script.c_str(), &workflow);
         mmi_custom_workflow_instance_create(workflow, &m_instance);
+        mmi_workflow_destroy(workflow);
     }
     void destroy_instance() {
         if (!m_instance) {

diff --git a/src/mmi/mmi-workflow.cpp b/src/mmi/mmi-workflow.cpp
index 05b703e79cd7e6a3181361f29f5a73804cb43cb2..b338db930b5d2937dccedf47127d3ab10d3d8c64 100644 (file)
--- a/src/mmi/mmi-workflow.cpp
+++ b/src/mmi/mmi-workflow.cpp
@@ -343,7 +343,7 @@ MMI_API int mmi_workflow_clone(mmi_workflow_h workflow, mmi_workflow_h *cloned)
         if (nullptr == cloned_s->node_infos) {
     // LCOV_EXCL_START
             LOGE("[ERROR] new mmi_workflow_node_info_s failed");
-            mmi_workflow_destroy(workflow_s);
+            mmi_workflow_destroy(cloned_s);
             return MMI_ERROR_OUT_OF_MEMORY;
     // LCOV_EXCL_STOP
         }
@@ -359,7 +359,7 @@ MMI_API int mmi_workflow_clone(mmi_workflow_h workflow, mmi_workflow_h *cloned)
         if (nullptr == cloned_s->link_infos) {
     // LCOV_EXCL_START
             LOGE("[ERROR] new mmi_workflow_link_info_s failed");
-            mmi_workflow_destroy(workflow_s);
+            mmi_workflow_destroy(cloned_s);
             return MMI_ERROR_OUT_OF_MEMORY;
     // LCOV_EXCL_STOP
         }
@@ -371,7 +371,7 @@ MMI_API int mmi_workflow_clone(mmi_workflow_h workflow, mmi_workflow_h *cloned)
         if (nullptr == cloned_s->attribute_assignment_infos) {
     // LCOV_EXCL_START
             LOGE("[ERROR] new mmi_workflow_attribute_assignment_info_s failed");
-            mmi_workflow_destroy(workflow_s);
+            mmi_workflow_destroy(cloned_s);
             return MMI_ERROR_OUT_OF_MEMORY;
     // LCOV_EXCL_STOP
         }
@@ -385,7 +385,7 @@ MMI_API int mmi_workflow_clone(mmi_workflow_h workflow, mmi_workflow_h *cloned)
         if (nullptr == cloned_s->attribute_default_value_infos) {
     // LCOV_EXCL_START
             LOGE("[ERROR] new mmi_workflow_attribute_default_value_info_s failed");
-            mmi_workflow_destroy(workflow_s);
+            mmi_workflow_destroy(cloned_s);
             return MMI_ERROR_OUT_OF_MEMORY;
     // LCOV_EXCL_STOP
         }
@@ -398,7 +398,7 @@ MMI_API int mmi_workflow_clone(mmi_workflow_h workflow, mmi_workflow_h *cloned)
             if (nullptr == cloned_s->attribute_default_value_infos[i].serialized_default_value) {
         // LCOV_EXCL_START
                 LOGE("[ERROR] new unsigned char failed");
-                mmi_workflow_destroy(workflow_s);
+                mmi_workflow_destroy(cloned_s);
                 return MMI_ERROR_OUT_OF_MEMORY;
         // LCOV_EXCL_STOP
             }
@@ -413,7 +413,7 @@ MMI_API int mmi_workflow_clone(mmi_workflow_h workflow, mmi_workflow_h *cloned)
         if (nullptr == cloned_s->output_assignment_infos) {
     // LCOV_EXCL_START
             LOGE("[ERROR] new mmi_workflow_output_assignment_info_s failed");
-            mmi_workflow_destroy(workflow_s);
+            mmi_workflow_destroy(cloned_s);
             return MMI_ERROR_OUT_OF_MEMORY;
     // LCOV_EXCL_STOP
         }