spi: pic32: fixup wait_for_completion_timeout return handling
authorNicholas Mc Guire <hofrat@osadl.org>
Sat, 23 Jul 2016 19:31:20 +0000 (21:31 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 24 Jul 2016 20:49:16 +0000 (21:49 +0100)
wait_for_completion_timeout returns unsigned long not int so the check for
<= 0 should be == 0 here.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pic32.c

index 73db87f..fefb688 100644 (file)
@@ -507,6 +507,7 @@ static int pic32_spi_one_transfer(struct spi_master *master,
 {
        struct pic32_spi *pic32s;
        bool dma_issued = false;
+       unsigned long timeout;
        int ret;
 
        pic32s = spi_master_get_devdata(master);
@@ -553,8 +554,8 @@ static int pic32_spi_one_transfer(struct spi_master *master,
        }
 
        /* wait for completion */
-       ret = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ);
-       if (ret <= 0) {
+       timeout = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ);
+       if (timeout == 0) {
                dev_err(&spi->dev, "wait error/timedout\n");
                if (dma_issued) {
                        dmaengine_terminate_all(master->dma_rx);