iommu/amd: Return -ENODEV in add_device when device is not handled by IOMMU
authorJoerg Roedel <jroedel@suse.de>
Wed, 29 Apr 2020 13:36:44 +0000 (15:36 +0200)
committerJoerg Roedel <jroedel@suse.de>
Tue, 5 May 2020 12:36:12 +0000 (14:36 +0200)
When check_device() fails on the device, it is not handled by the
IOMMU and amd_iommu_add_device() needs to return -ENODEV.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
Link: https://lore.kernel.org/r/20200429133712.31431-7-joro@8bytes.org
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/amd_iommu.c

index 504f2db..3e0d27f 100644 (file)
@@ -2157,9 +2157,12 @@ static int amd_iommu_add_device(struct device *dev)
        struct amd_iommu *iommu;
        int ret, devid;
 
-       if (!check_device(dev) || get_dev_data(dev))
+       if (get_dev_data(dev))
                return 0;
 
+       if (!check_device(dev))
+               return -ENODEV;
+
        devid = get_device_id(dev);
        if (devid < 0)
                return devid;