usb: gadget: function: Simplify diagnostic messaging in printer

Don't issue messages which can be easily achieved with ftrace.
In case of printer_open() the return code is propagated to other layers
so the user will know about -EBUSY anyway.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Link: https://lore.kernel.org/r/20221123110746.59611-1-andrzej.p@collabora.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
index a881c69b1f2bf56cf20fda287efcd708e7abdbe3..4903d761a87241d85c8528285c052d5adb85c1e4 100644 (file)
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -364,7 +364,7 @@ printer_open(struct inode *inode, struct file *fd)
        spin_unlock_irqrestore(&dev->lock, flags);
 
        kref_get(&dev->kref);
-       DBG(dev, "printer_open returned %x\n", ret);
+
        return ret;
 }
 
@@ -382,7 +382,6 @@ printer_close(struct inode *inode, struct file *fd)
        spin_unlock_irqrestore(&dev->lock, flags);
 
        kref_put(&dev->kref, printer_dev_free);
-       DBG(dev, "printer_close\n");
 
        return 0;
 }
@@ -848,8 +847,6 @@ static void printer_reset_interface(struct printer_dev *dev)
        if (dev->interface < 0)
                return;
 
-       DBG(dev, "%s\n", __func__);
-
        if (dev->in_ep->desc)
                usb_ep_disable(dev->in_ep);
 
@@ -887,8 +884,6 @@ static void printer_soft_reset(struct printer_dev *dev)
 {
        struct usb_request      *req;
 
-       INFO(dev, "Received Printer Reset Request\n");
-
        if (usb_ep_disable(dev->in_ep))
                DBG(dev, "Failed to disable USB in_ep\n");
        if (usb_ep_disable(dev->out_ep))
@@ -1185,8 +1180,6 @@ static void printer_func_disable(struct usb_function *f)
 {
        struct printer_dev *dev = func_to_printer(f);
 
-       DBG(dev, "%s\n", __func__);
-
        printer_reset_interface(dev);
 }