media: mb86a20s: make arrays static const
authorColin Ian King <colin.king@canonical.com>
Wed, 15 Sep 2021 11:56:00 +0000 (13:56 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 8 Oct 2021 11:43:54 +0000 (13:43 +0200)
Don't populate the read-only arrays on the stack but instead them
static const. Also makes the object code smaller by 154 bytes:

Before:
   text    data     bss     dec     hex filename
  42949   22424       0   65373    ff5d media/dvb-frontends/mb86a20s.o

After:
   text    data     bss     dec     hex filename
  42731   22488       0   65219    fec3 media/dvb-frontends/mb86a20s.o

(gcc version 11.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/dvb-frontends/mb86a20s.c

index a7faf0c..b74b9af 100644 (file)
@@ -444,11 +444,11 @@ static int mb86a20s_get_interleaving(struct mb86a20s_state *state,
                                     unsigned layer)
 {
        int rc;
-       int interleaving[] = {
+       static const int interleaving[] = {
                0, 1, 2, 4, 8
        };
 
-       static unsigned char reg[] = {
+       static const unsigned char reg[] = {
                [0] = 0x88,     /* Layer A */
                [1] = 0x8c,     /* Layer B */
                [2] = 0x90,     /* Layer C */