extcon: max14577: Properly handle regmap_irq_get_virq error
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fri, 18 Apr 2014 14:47:30 +0000 (16:47 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 Jul 2014 03:11:52 +0000 (20:11 -0700)
commit 369afd4ba22f5b8de0c9229b6e62b3f9e2207034 upstream.

The regmap_irq_get_virq may return 0 or -EINVAL on error. Fail the probe
in both situations.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/extcon/extcon-max14577.c

index 1fef08d..5c948c9 100644 (file)
@@ -650,7 +650,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
                unsigned int virq = 0;
 
                virq = regmap_irq_get_virq(max14577->irq_data, muic_irq->irq);
-               if (!virq)
+               if (virq <= 0)
                        return -EINVAL;
                muic_irq->virq = virq;