perf trace: Add beautifier for lseek's whence arg
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 2 Sep 2013 18:37:32 +0000 (15:37 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 2 Sep 2013 18:37:32 +0000 (15:37 -0300)
 [root@zoo ~]# perf trace -a -e lseek | head -1
    546.922 ( 0.004 ms): 1184 lseek(fd: 26, offset: 0, whence: CUR) = 2
 [root@zoo ~]#

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-2eiuhwz9jbnhj80q6jaqeji4@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-trace.c

index 1a6cb74..02aaea6 100644 (file)
@@ -24,6 +24,31 @@ static size_t syscall_arg__scnprintf_hex(char *bf, size_t size,
 
 #define SCA_HEX syscall_arg__scnprintf_hex
 
+static size_t syscall_arg__scnprintf_whence(char *bf, size_t size,
+                                           unsigned long arg, u8 *arg_mask __maybe_unused)
+{
+       int whence = arg;
+
+       switch (whence) {
+#define P_WHENCE(n) case SEEK_##n: return scnprintf(bf, size, #n)
+       P_WHENCE(SET);
+       P_WHENCE(CUR);
+       P_WHENCE(END);
+#ifdef SEEK_DATA
+       P_WHENCE(DATA);
+#endif
+#ifdef SEEK_HOLE
+       P_WHENCE(HOLE);
+#endif
+#undef P_WHENCE
+       default: break;
+       }
+
+       return scnprintf(bf, size, "%#x", whence);
+}
+
+#define SCA_WHENCE syscall_arg__scnprintf_whence
+
 static size_t syscall_arg__scnprintf_mmap_prot(char *bf, size_t size,
                                               unsigned long arg, u8 *arg_mask __maybe_unused)
 {
@@ -201,6 +226,8 @@ static struct syscall_fmt {
          .arg_scnprintf = { [1] = SCA_FUTEX_OP, /* op */ }, },
        { .name     = "ioctl",      .errmsg = true,
          .arg_scnprintf = { [2] = SCA_HEX, /* arg */ }, },
+       { .name     = "lseek",      .errmsg = true,
+         .arg_scnprintf = { [2] = SCA_WHENCE, /* whence */ }, },
        { .name     = "lstat",      .errmsg = true, .alias = "newlstat", },
        { .name     = "madvise",    .errmsg = true,
          .arg_scnprintf = { [0] = SCA_HEX,      /* start */