[media] exynos4-is: Put node before s5pcsis_parse_dt() return error
authorJavier Martinez Canillas <javier@osg.samsung.com>
Fri, 4 Mar 2016 20:20:12 +0000 (17:20 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 13 Apr 2016 19:23:14 +0000 (16:23 -0300)
The MIPI CSIS DT parse function return an -ENXIO errno if the port #
is outside of the supported values. But it doesn't call of_node_put()
to decrement the node's reference counter, that's incremented inside
the of_graph_get_next_endpoint() function that was called before.

Instead of just returning, go to the error path that already does it.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/exynos4-is/mipi-csis.c

index bd5c46c..bf95442 100644 (file)
@@ -757,8 +757,10 @@ static int s5pcsis_parse_dt(struct platform_device *pdev,
                goto err;
 
        state->index = endpoint.base.port - FIMC_INPUT_MIPI_CSI2_0;
-       if (state->index >= CSIS_MAX_ENTITIES)
-               return -ENXIO;
+       if (state->index >= CSIS_MAX_ENTITIES) {
+               ret = -ENXIO;
+               goto err;
+       }
 
        /* Get MIPI CSI-2 bus configration from the endpoint node. */
        of_property_read_u32(node, "samsung,csis-hs-settle",