crypto: marvell/octeontx - simplify the return expression of create_sysfs_eng_grps_info()
authorQinglang Miao <miaoqinglang@huawei.com>
Mon, 21 Sep 2020 13:10:07 +0000 (21:10 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 2 Oct 2020 08:02:10 +0000 (18:02 +1000)
Simplify the return expression.

Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c

index cc103b1..40b4821 100644 (file)
@@ -824,18 +824,12 @@ static ssize_t eng_grp_info_show(struct device *dev,
 static int create_sysfs_eng_grps_info(struct device *dev,
                                      struct otx_cpt_eng_grp_info *eng_grp)
 {
-       int ret;
-
        eng_grp->info_attr.show = eng_grp_info_show;
        eng_grp->info_attr.store = NULL;
        eng_grp->info_attr.attr.name = eng_grp->sysfs_info_name;
        eng_grp->info_attr.attr.mode = 0440;
        sysfs_attr_init(&eng_grp->info_attr.attr);
-       ret = device_create_file(dev, &eng_grp->info_attr);
-       if (ret)
-               return ret;
-
-       return 0;
+       return device_create_file(dev, &eng_grp->info_attr);
 }
 
 static void ucode_unload(struct device *dev, struct otx_cpt_ucode *ucode)