typefind: remove pointless checks for data being NULL

It was already checked in an early out, and as it's only
incremented for at most the size of the passed buffer, it
can only become NULL in an address wraparound.

While there, don't cast away const on a pointer.

Coverity 1139845

diff --git a/gst/typefind/gsttypefindfunctions.c b/gst/typefind/gsttypefindfunctions.c
index 78907ef9c6c3004f4979fbc6ac7691bf041f6c5b..031d3d749d8ceedf0ae953d284add7f679c21c70 100644 (file)
--- a/gst/typefind/gsttypefindfunctions.c
+++ b/gst/typefind/gsttypefindfunctions.c
@@ -517,7 +517,7 @@ xml_check_first_element_from_data (const guint8 * data, guint length,
 
   /* look for the first element, it has to be the requested element. Bail
    * out if it is not within the first 4kB. */
-  while (data && pos < MIN (4096, length)) {
+  while (pos < MIN (4096, length)) {
     while (*data != '<' && pos < MIN (4096, length)) {
       XML_INC_BUFFER_DATA;
     }
@@ -533,7 +533,7 @@ xml_check_first_element_from_data (const guint8 * data, guint length,
     /* the first normal element, check if it's the one asked for */
     if (pos + elen + 1 >= length)
       return FALSE;
-    return (data && element && strncmp ((char *) data, element, elen) == 0);
+    return (element && strncmp ((const char *) data, element, elen) == 0);
   }
 
   return FALSE;