mesa: OpenGL 1.4 feature GL_EXT_blend_minmax is not optional
authorIan Romanick <ian.d.romanick@intel.com>
Wed, 15 Dec 2021 01:47:55 +0000 (17:47 -0800)
committerMarge Bot <emma+marge@anholt.net>
Fri, 21 Jan 2022 22:08:33 +0000 (22:08 +0000)
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14213>

src/mesa/main/blend.c
src/mesa/main/consts_exts.h
src/mesa/main/extensions.c
src/mesa/main/extensions_table.h
src/mesa/main/version.c

index 0bc21a4..0615071 100644 (file)
@@ -447,10 +447,9 @@ legal_simple_blend_equation(const struct gl_context *ctx, GLenum mode)
    case GL_FUNC_ADD:
    case GL_FUNC_SUBTRACT:
    case GL_FUNC_REVERSE_SUBTRACT:
-      return GL_TRUE;
    case GL_MIN:
    case GL_MAX:
-      return ctx->Extensions.EXT_blend_minmax;
+      return GL_TRUE;
    default:
       return GL_FALSE;
    }
index 94bde18..617e853 100644 (file)
@@ -162,7 +162,6 @@ struct gl_extensions
    GLboolean ARB_vertex_type_2_10_10_10_rev;
    GLboolean ARB_viewport_array;
    GLboolean EXT_blend_equation_separate;
-   GLboolean EXT_blend_minmax;
    GLboolean EXT_demote_to_helper_invocation;
    GLboolean EXT_depth_bounds_test;
    GLboolean EXT_disjoint_timer_query;
index 11291cb..328ddcd 100644 (file)
@@ -281,7 +281,6 @@ _mesa_init_extensions(struct gl_extensions *extensions)
    extensions->ARB_vertex_program = GL_TRUE;
    extensions->ARB_vertex_shader = GL_TRUE;
 
-   extensions->EXT_blend_minmax = GL_TRUE;
    extensions->EXT_EGL_image_storage = GL_TRUE;
    extensions->EXT_gpu_program_parameters = GL_TRUE;
    extensions->EXT_pixel_buffer_object = GL_TRUE;
index 4d9416b..f77a37c 100644 (file)
@@ -218,7 +218,7 @@ EXT(EXT_blend_color                         , dummy_true
 EXT(EXT_blend_equation_separate             , EXT_blend_equation_separate            , GLL, GLC,  x ,  x , 2003)
 EXT(EXT_blend_func_extended                 , ARB_blend_func_extended                ,  x ,  x ,  x , ES2, 2015)
 EXT(EXT_blend_func_separate                 , dummy_true                             , GLL,  x ,  x ,  x , 1999)
-EXT(EXT_blend_minmax                        , EXT_blend_minmax                       , GLL,  x , ES1, ES2, 1995)
+EXT(EXT_blend_minmax                        , dummy_true                             , GLL,  x , ES1, ES2, 1995)
 EXT(EXT_blend_subtract                      , dummy_true                             , GLL,  x ,  x ,  x , 1995)
 EXT(EXT_buffer_storage                      , ARB_buffer_storage                     ,  x ,  x ,  x ,  31, 2015)
 EXT(EXT_clear_texture                       , ARB_clear_texture                      ,  x ,  x ,  x ,  31, 2016)
index e042de4..5a4b691 100644 (file)
@@ -252,7 +252,6 @@ compute_version(const struct gl_extensions *extensions,
    GLuint major, minor, version;
 
    const bool ver_1_4 = (extensions->ARB_shadow &&
-                         extensions->EXT_blend_minmax &&
                          extensions->EXT_point_parameters);
    const bool ver_1_5 = (ver_1_4 &&
                          extensions->ARB_occlusion_query);
@@ -495,8 +494,7 @@ compute_version_es2(const struct gl_extensions *extensions,
                     const struct gl_constants *consts)
 {
    /* OpenGL ES 2.0 is derived from OpenGL 2.0 */
-   const bool ver_2_0 = (extensions->EXT_blend_minmax &&
-                         extensions->ARB_vertex_shader &&
+   const bool ver_2_0 = (extensions->ARB_vertex_shader &&
                          extensions->ARB_fragment_shader &&
                          extensions->ARB_texture_non_power_of_two &&
                          extensions->EXT_blend_equation_separate);