playbin: Fix memory leak in autoplugging code

We should not leak element factories ideally.

diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c
index 85a4195502bb6a9006080f0faaabcf1fae223e0d..a105e8f355440cd79605e04b5c92c9f8dce5cb43 100644 (file)
--- a/gst/playback/gstplaybin2.c
+++ b/gst/playback/gstplaybin2.c
@@ -3838,7 +3838,7 @@ create_decoders_list (GList * factory_list, GSequence * avelements)
             GST_ELEMENT_FACTORY_TYPE_PARSER) ||
         gst_element_factory_list_is_type (factory,
             GST_ELEMENT_FACTORY_TYPE_SINK)) {
-      dec_list = g_list_prepend (dec_list, factory);
+      dec_list = g_list_prepend (dec_list, gst_object_ref (factory));
     } else {
       GSequenceIter *seq_iter;
 
@@ -3890,9 +3890,10 @@ create_decoders_list (GList * factory_list, GSequence * avelements)
   ave_list = g_list_sort (ave_list, (GCompareFunc) avelement_compare);
   for (tmp = ave_list; tmp; tmp = tmp->next) {
     ave = (GstAVElement *) tmp->data;
-    dec_list = g_list_prepend (dec_list, ave->dec);
+    dec_list = g_list_prepend (dec_list, gst_object_ref (ave->dec));
   }
   g_list_free (ave_list);
+  gst_plugin_feature_list_free (factory_list);
 
   for (tmp = ave_free_list; tmp; tmp = tmp->next)
     g_slice_free (GstAVElement, tmp->data);