drm/msm/dpu: use kms stored hw mdp block
authorJeykumar Sankaran <jsanka@codeaurora.org>
Thu, 6 Sep 2018 02:08:16 +0000 (19:08 -0700)
committerRob Clark <robdclark@gmail.com>
Thu, 4 Oct 2018 00:24:51 +0000 (20:24 -0400)
Avoid querying RM for hw mdp block. Use the one
stored in KMS during initialization.

changes in v4:
- none
changes in v5:
- none

Signed-off-by: Jeykumar Sankaran <jsanka@codeaurora.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c

index 3084675..c8c4612 100644 (file)
@@ -823,7 +823,6 @@ struct dpu_encoder_phys *dpu_encoder_phys_cmd_init(
 {
        struct dpu_encoder_phys *phys_enc = NULL;
        struct dpu_encoder_phys_cmd *cmd_enc = NULL;
-       struct dpu_hw_mdp *hw_mdp;
        struct dpu_encoder_irq *irq;
        int i, ret = 0;
 
@@ -836,14 +835,7 @@ struct dpu_encoder_phys *dpu_encoder_phys_cmd_init(
                goto fail;
        }
        phys_enc = &cmd_enc->base;
-
-       hw_mdp = dpu_rm_get_mdp(&p->dpu_kms->rm);
-       if (IS_ERR_OR_NULL(hw_mdp)) {
-               ret = PTR_ERR(hw_mdp);
-               DPU_ERROR("failed to get mdptop\n");
-               goto fail_mdp_init;
-       }
-       phys_enc->hw_mdptop = hw_mdp;
+       phys_enc->hw_mdptop = p->dpu_kms->hw_mdp;
        phys_enc->intf_idx = p->intf_idx;
 
        dpu_encoder_phys_cmd_init_ops(&phys_enc->ops);
@@ -898,8 +890,6 @@ struct dpu_encoder_phys *dpu_encoder_phys_cmd_init(
 
        return phys_enc;
 
-fail_mdp_init:
-       kfree(cmd_enc);
 fail:
        return ERR_PTR(ret);
 }
index 6fc3d3f..ecb8c65 100644 (file)
@@ -801,7 +801,6 @@ struct dpu_encoder_phys *dpu_encoder_phys_vid_init(
        struct dpu_encoder_phys *phys_enc = NULL;
        struct dpu_encoder_phys_vid *vid_enc = NULL;
        struct dpu_rm_hw_iter iter;
-       struct dpu_hw_mdp *hw_mdp;
        struct dpu_encoder_irq *irq;
        int i, ret = 0;
 
@@ -818,13 +817,7 @@ struct dpu_encoder_phys *dpu_encoder_phys_vid_init(
 
        phys_enc = &vid_enc->base;
 
-       hw_mdp = dpu_rm_get_mdp(&p->dpu_kms->rm);
-       if (IS_ERR_OR_NULL(hw_mdp)) {
-               ret = PTR_ERR(hw_mdp);
-               DPU_ERROR("failed to get mdptop\n");
-               goto fail;
-       }
-       phys_enc->hw_mdptop = hw_mdp;
+       phys_enc->hw_mdptop = p->dpu_kms->hw_mdp;
        phys_enc->intf_idx = p->intf_idx;
 
        /**