drm/amdgpu: Fix sigsev when accessing MMIO on hot unplug.
authorAndrey Grodzovsky <andrey.grodzovsky@amd.com>
Tue, 1 Mar 2022 00:03:36 +0000 (19:03 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 2 Mar 2022 23:40:06 +0000 (18:40 -0500)
Protect with drm_dev_enter/exit

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c

index f522b52..4294f17 100644 (file)
@@ -23,6 +23,7 @@
  */
 
 #include <drm/drm_auth.h>
+#include <drm/drm_drv.h>
 #include "amdgpu.h"
 #include "amdgpu_sched.h"
 #include "amdgpu_ras.h"
@@ -339,7 +340,7 @@ static void amdgpu_ctx_fini(struct kref *ref)
 {
        struct amdgpu_ctx *ctx = container_of(ref, struct amdgpu_ctx, refcount);
        struct amdgpu_device *adev = ctx->adev;
-       unsigned i, j;
+       unsigned i, j, idx;
 
        if (!adev)
                return;
@@ -350,7 +351,12 @@ static void amdgpu_ctx_fini(struct kref *ref)
                        ctx->entities[i][j] = NULL;
                }
        }
-       amdgpu_ctx_set_stable_pstate(ctx, AMDGPU_CTX_STABLE_PSTATE_NONE);
+
+       if (drm_dev_enter(&adev->ddev, &idx)) {
+               amdgpu_ctx_set_stable_pstate(ctx, AMDGPU_CTX_STABLE_PSTATE_NONE);
+               drm_dev_exit(idx);
+       }
+
        kfree(ctx);
 }