iommu/dma: Fix IOVA reserve dma ranges
authorSrinath Mannam <srinath.mannam@broadcom.com>
Mon, 14 Sep 2020 07:23:19 +0000 (12:53 +0530)
committerJoerg Roedel <jroedel@suse.de>
Tue, 8 Jun 2021 12:15:02 +0000 (14:15 +0200)
Fix IOVA reserve failure in the case when address of first memory region
listed in dma-ranges is equal to 0x0.

Fixes: aadad097cd46f ("iommu/dma: Reserve IOVA for PCIe inaccessible DMA address")
Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Tested-by: Sven Peter <sven@svenpeter.dev>
Link: https://lore.kernel.org/r/20200914072319.6091-1-srinath.mannam@broadcom.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/dma-iommu.c

index 7bcdd12..95e7349 100644 (file)
@@ -243,9 +243,11 @@ resv_iova:
                        lo = iova_pfn(iovad, start);
                        hi = iova_pfn(iovad, end);
                        reserve_iova(iovad, lo, hi);
-               } else {
+               } else if (end < start) {
                        /* dma_ranges list should be sorted */
-                       dev_err(&dev->dev, "Failed to reserve IOVA\n");
+                       dev_err(&dev->dev,
+                               "Failed to reserve IOVA [%#010llx-%#010llx]\n",
+                               start, end);
                        return -EINVAL;
                }