bluetooth: update device's valid flag after parsing properties
authorTanu Kaskinen <tanuk@iki.fi>
Sun, 7 Aug 2016 15:45:51 +0000 (18:45 +0300)
committerTanu Kaskinen <tanuk@iki.fi>
Wed, 10 Aug 2016 18:37:33 +0000 (21:37 +0300)
The properties_received flag affects whether the device should be
considered valid, so let's update the valid flag after setting the
properties_received flag.

There's a call to device_update_valid() anyway later when setting
the device adapters, so this change isn't strictly necessary, but
this makes it more obvious that the code is correct (and less
fragile).

src/modules/bluetooth/bluez5-util.c

index e4cf044..890b8ec 100644 (file)
@@ -773,6 +773,7 @@ static void parse_device_properties(pa_bluetooth_device *d, DBusMessageIter *i)
 
     if (!d->properties_received) {
         d->properties_received = true;
+        device_update_valid(d);
 
         if (!d->address || !d->adapter_path || !d->alias)
             pa_log_error("Non-optional information missing for device %s", d->path);