staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_pwrctrl.c
authorPhillip Potter <phil@philpotter.co.uk>
Fri, 25 Jun 2021 00:07:48 +0000 (01:07 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Jun 2021 07:03:51 +0000 (09:03 +0200)
Remove all RT_TRACE calls from core/rtw_pwrctrl.c as this macro is
unnecessary, and these calls are dubious in terms of necessity.
Removing all calls will ultimately allow the removal of the macro
itself.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210625000756.6313-16-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c

index 95e2eea..cbb34b9 100644 (file)
@@ -265,37 +265,22 @@ void rtw_set_rpwm(struct adapter *padapter, u8 pslv)
                        pslv = PS_STATE_S3;
        }
 
-       if (pwrpriv->rpwm == pslv) {
-               RT_TRACE(_module_rtl871x_pwrctrl_c_, _drv_err_,
-                        ("%s: Already set rpwm[0x%02X], new=0x%02X!\n", __func__, pwrpriv->rpwm, pslv));
+       if (pwrpriv->rpwm == pslv)
                return;
-       }
 
        if ((padapter->bSurpriseRemoved) ||
            (!padapter->hw_init_completed)) {
-               RT_TRACE(_module_rtl871x_pwrctrl_c_, _drv_err_,
-                        ("%s: SurpriseRemoved(%d) hw_init_completed(%d)\n",
-                        __func__, padapter->bSurpriseRemoved, padapter->hw_init_completed));
-
                pwrpriv->cpwm = PS_STATE_S4;
 
                return;
        }
 
        if (padapter->bDriverStopped) {
-               RT_TRACE(_module_rtl871x_pwrctrl_c_, _drv_err_,
-                        ("%s: change power state(0x%02X) when DriverStopped\n", __func__, pslv));
-
-               if (pslv < PS_STATE_S2) {
-                       RT_TRACE(_module_rtl871x_pwrctrl_c_, _drv_err_,
-                                ("%s: Reject to enter PS_STATE(0x%02X) lower than S2 when DriverStopped!!\n", __func__, pslv));
+               if (pslv < PS_STATE_S2)
                        return;
-               }
        }
 
        rpwm = pslv | pwrpriv->tog;
-       RT_TRACE(_module_rtl871x_pwrctrl_c_, _drv_notice_,
-                ("%s: rpwm=0x%02x cpwm=0x%02x\n", __func__, rpwm, pwrpriv->cpwm));
 
        pwrpriv->rpwm = pslv;
 
@@ -335,14 +320,8 @@ void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode, u8 smart_ps, u8 bcn_a
 {
        struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
 
-       RT_TRACE(_module_rtl871x_pwrctrl_c_, _drv_notice_,
-                ("%s: PowerMode=%d Smart_PS=%d\n",
-                 __func__, ps_mode, smart_ps));
-
-       if (ps_mode > PM_Card_Disable) {
-               RT_TRACE(_module_rtl871x_pwrctrl_c_, _drv_err_, ("ps_mode:%d error\n", ps_mode));
+       if (ps_mode > PM_Card_Disable)
                return;
-       }
 
        if (pwrpriv->pwr_mode == ps_mode) {
                if (ps_mode == PS_MODE_ACTIVE)