Fix EqualsIgnoreCaseUtf8_Scalar (#89152)
authorEgor Bogatov <egorbo@gmail.com>
Wed, 19 Jul 2023 03:59:33 +0000 (05:59 +0200)
committerGitHub <noreply@github.com>
Wed, 19 Jul 2023 03:59:33 +0000 (23:59 -0400)
* Fix EqualsIgnoreCaseUtf8_Scalar

* revert change

* Remove activeissue

src/libraries/System.Private.CoreLib/src/System/Globalization/Ordinal.Utf8.cs
src/libraries/System.Text.Json/tests/Common/NumberHandlingTests.cs

index e1e7087..1d715f7 100644 (file)
@@ -296,13 +296,7 @@ namespace System.Globalization
                     return true;
                 }
 
-                if (!Utf8Utility.UInt32OrdinalIgnoreCaseAscii(valueAu32, valueBu32))
-                {
-                    return false;
-                }
-
-                byteOffset += 4;
-                length -= 4;
+                return Utf8Utility.UInt32OrdinalIgnoreCaseAscii(valueAu32, valueBu32);
             }
 
             Debug.Assert(length == 0);
index 2a2e2dd..109123b 100644 (file)
@@ -873,7 +873,6 @@ namespace System.Text.Json.Serialization.Tests
         [InlineData("\u0020Inf\u0069ni\u0074y")] // " Infinity"
         [InlineData("\u002BInf\u0069nity")] // "+Infinity"
 #pragma warning restore xUnit1025
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/89094", TestPlatforms.OSX)]
         public async Task FloatingPointConstants_Fail(string testString)
         {
             string testStringAsJson = $@"""{testString}""";