fsi: master-ast-cf: Remove redundant error printing in fsi_master_acf_probe()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 08:57:45 +0000 (16:57 +0800)
committerJoel Stanley <joel@jms.id.au>
Fri, 4 Jun 2021 05:32:55 +0000 (15:02 +0930)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://patchwork.ozlabs.org/project/linux-fsi/patch/20210511085745.4340-1-thunder.leizhen@huawei.com/
Signed-off-by: Joel Stanley <joel@jms.id.au>
drivers/fsi/fsi-master-ast-cf.c

index 70c03e3..24292ac 100644 (file)
@@ -1309,7 +1309,6 @@ static int fsi_master_acf_probe(struct platform_device *pdev)
        master->cf_mem = devm_ioremap_resource(&pdev->dev, &res);
        if (IS_ERR(master->cf_mem)) {
                rc = PTR_ERR(master->cf_mem);
-               dev_err(&pdev->dev, "Error %d mapping coldfire memory\n", rc);
                goto err_free;
        }
        dev_dbg(&pdev->dev, "DRAM allocation @%x\n", master->cf_mem_addr);