greybus: gpio: remove incorrect todo comments
authorJohan Hovold <johan@hovoldconsulting.com>
Thu, 19 Mar 2015 15:51:10 +0000 (16:51 +0100)
committerGreg Kroah-Hartman <greg@kroah.com>
Thu, 19 Mar 2015 16:29:40 +0000 (17:29 +0100)
The module reference count is incremented by gpiolib when a gpio is
requested, and the driver callbacks certainly do sleep.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
drivers/staging/greybus/gpio.c

index f75dd40..6a493d4 100644 (file)
@@ -747,7 +747,7 @@ static int gb_gpio_connection_init(struct gb_connection *connection)
 
        gpio->label = "greybus_gpio";
        gpio->dev = &connection->dev;
-       gpio->owner = THIS_MODULE;      /* XXX Module get? */
+       gpio->owner = THIS_MODULE;
 
        gpio->request = gb_gpio_request;
        gpio->free = gb_gpio_free;
@@ -761,7 +761,7 @@ static int gb_gpio_connection_init(struct gb_connection *connection)
        gpio->to_irq = gb_gpio_to_irq;
        gpio->base = -1;                /* Allocate base dynamically */
        gpio->ngpio = gb_gpio_controller->line_max + 1;
-       gpio->can_sleep = true;         /* XXX */
+       gpio->can_sleep = true;
 
        ret = gpiochip_add(gpio);
        if (ret) {