projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3a5daa8
)
soc: samsung: exynos-asv: handle reading revision register error
author
Krzysztof Kozlowski
<krzk@kernel.org>
Mon, 7 Dec 2020 19:05:15 +0000
(20:05 +0100)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 4 Mar 2021 10:38:32 +0000
(11:38 +0100)
commit
4561560dfb4f847a0b327d48bdd1f45bf1b6261f
upstream.
If regmap_read() fails, the product_id local variable will contain
random value from the stack. Do not try to parse such value and fail
the ASV driver probe.
Fixes:
5ea428595cc5
("soc: samsung: Add Exynos Adaptive Supply Voltage driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Link:
https://lore.kernel.org/r/20201207190517.262051-3-krzk@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/soc/samsung/exynos-asv.c
patch
|
blob
|
history
diff --git
a/drivers/soc/samsung/exynos-asv.c
b/drivers/soc/samsung/exynos-asv.c
index
f653e35
..
5daeadc
100644
(file)
--- a/
drivers/soc/samsung/exynos-asv.c
+++ b/
drivers/soc/samsung/exynos-asv.c
@@
-129,7
+129,13
@@
static int exynos_asv_probe(struct platform_device *pdev)
return PTR_ERR(asv->chipid_regmap);
}
- regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id);
+ ret = regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID,
+ &product_id);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "Cannot read revision from ChipID: %d\n",
+ ret);
+ return -ENODEV;
+ }
switch (product_id & EXYNOS_MASK) {
case 0xE5422000: