decodebin: Include codec description for missing plugins in the error message
authorSebastian Dröge <sebastian@centricular.com>
Tue, 2 Sep 2014 09:59:18 +0000 (12:59 +0300)
committerSebastian Dröge <sebastian@centricular.com>
Tue, 2 Sep 2014 10:00:48 +0000 (13:00 +0300)
If we had plugins and an error occurred we only include the error message
caused by this, otherwise we will include the codec description as generated
from the caps.

This allows to detect which exact codec was missing instead of getting a
generic "no suitable decoders found" error message.

gst/playback/gstdecodebin2.c

index 4076769..8174067 100644 (file)
@@ -4316,6 +4316,11 @@ gst_decode_chain_expose (GstDecodeChain * chain, GList ** endpads,
       if (chain->deadend_details) {
         g_string_append (missing_plugin_details, chain->deadend_details);
         g_string_append_c (missing_plugin_details, '\n');
+      } else {
+        gchar *desc = gst_pb_utils_get_codec_description (chain->endcaps);
+        g_string_append_printf (missing_plugin_details, "Missing decoder: %s\n",
+            desc);
+        g_free (desc);
       }
       *missing_plugin = TRUE;
     }