atmel: Replace mdelay() with msleep() in probe_atmel_card()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 08:45:35 +0000 (16:45 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 31 Jul 2018 07:25:33 +0000 (10:25 +0300)
probe_atmel_card() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/atmel/atmel.c

index f4f56f4..7453808 100644 (file)
@@ -3677,7 +3677,7 @@ static int probe_atmel_card(struct net_device *dev)
                atmel_write16(dev, GCR, 0x0060);
 
        atmel_write16(dev, GCR, 0x0040);
-       mdelay(500);
+       msleep(500);
 
        if (atmel_read16(dev, MR2) == 0) {
                /* No stored firmware so load a small stub which just