test: fix cluster-worker-isdead
authorSantiago Gimeno <santiago.gimeno@gmail.com>
Sat, 21 Nov 2015 14:33:51 +0000 (15:33 +0100)
committerJames M Snell <jasnell@gmail.com>
Wed, 23 Dec 2015 16:38:33 +0000 (08:38 -0800)
Check if the worker 'isDead' instead of 'isConnected' as the
'disconnect' event is not guaranteed to be received before the
'exit' event.
Remove the 'net' dependency as it is not used.

PR-URL: https://github.com/nodejs/node/pull/3954
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaƫl Zasso <mic.besace@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
test/parallel/test-cluster-worker-isdead.js

index 70a9653..90454cb 100644 (file)
@@ -2,7 +2,6 @@
 require('../common');
 var cluster = require('cluster');
 var assert = require('assert');
-var net = require('net');
 
 if (cluster.isMaster) {
   var worker = cluster.fork();
@@ -11,7 +10,7 @@ if (cluster.isMaster) {
             'created.');
 
   worker.on('exit', function() {
-    assert.ok(!worker.isConnected(),
+    assert.ok(worker.isDead(),
               'After an event has been emitted, ' +
               'isDead should return true');
   });