cipso: remove an unneeded NULL check in cipso_v4_doi_add()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 11 Oct 2011 22:43:53 +0000 (18:43 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 11 Oct 2011 22:43:53 +0000 (18:43 -0400)
We dereference doi_def on the line before the NULL check.  It has
been this way since 2008.  I checked all the callers and doi_def is
always non-NULL here.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/cipso_ipv4.c

index 2c2a98e..86f3b88 100644 (file)
@@ -476,7 +476,7 @@ int cipso_v4_doi_add(struct cipso_v4_doi *doi_def,
        doi = doi_def->doi;
        doi_type = doi_def->type;
 
-       if (doi_def == NULL || doi_def->doi == CIPSO_V4_DOI_UNKNOWN)
+       if (doi_def->doi == CIPSO_V4_DOI_UNKNOWN)
                goto doi_add_return;
        for (iter = 0; iter < CIPSO_V4_TAG_MAXCNT; iter++) {
                switch (doi_def->tags[iter]) {