ASoC: imx-card: Fix refcount issue with of_node_put
authorShengjiu Wang <shengjiu.wang@nxp.com>
Tue, 13 Sep 2022 09:00:01 +0000 (17:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Oct 2022 08:39:41 +0000 (10:39 +0200)
[ Upstream commit d56ba9a04d7548d4149c46ec86a0e3cc41a70f4a ]

imx_card_parse_of will search all the node with loop,
if there is defer probe happen in the middle of loop,
the previous released codec node will be released
twice, then cause refcount issue.

Here assign NULL to pointer of released nodes to fix
the issue.

Fixes: aa736700f42f ("ASoC: imx-card: Add imx-card machine driver")
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Link: https://lore.kernel.org/r/1663059601-29259-1-git-send-email-shengjiu.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/fsl/imx-card.c

index 593d69b..d59f5ef 100644 (file)
@@ -698,6 +698,10 @@ static int imx_card_parse_of(struct imx_card_data *data)
                of_node_put(cpu);
                of_node_put(codec);
                of_node_put(platform);
+
+               cpu = NULL;
+               codec = NULL;
+               platform = NULL;
        }
 
        return 0;