mmi-api-handler: fix to check return value from set_client_{event}_cb_handle() functi... 59/264059/1
authorSung-Jin Park <sj76.park@samsung.com>
Fri, 27 Aug 2021 08:58:07 +0000 (17:58 +0900)
committerSung-Jin Park <sj76.park@samsung.com>
Mon, 13 Sep 2021 11:25:15 +0000 (20:25 +0900)
As client_manager_set_client_{event}_cb_handle() will clone the given handle
and returns a handle which is different value with the given handle.
Therefore we just check the return value to check if the given handle has been
cloned successfully.

Change-Id: I9546b4050b0654a1ef55e423a7e87fb88a9df1a2
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
src/mmi-api-handler.c

index 75918f022ecbb076c2dcde0e0176e24960026ca7..f540e74a8b9cab19c0cecd3cbc1d4d1675f65f23 100644 (file)
@@ -106,49 +106,49 @@ static int _register_cb(rpc_port_stub_mmifw_context_h context, rpc_port_mmifw_fo
                goto err;
        }
 
-       if (focus_cb != client_manager_set_client_focus_cb_handle(mc, (void *)focus_cb))
+       if (!client_manager_set_client_focus_cb_handle(mc, (void *)focus_cb))
        {
                LOGE("Failed to set focus event handler to client info !\n");
                goto err;
        }
 
-       if (state_cb != client_manager_set_client_state_change_cb_handle(mc, (void *)state_cb))
+       if (!client_manager_set_client_state_change_cb_handle(mc, (void *)state_cb))
        {
                LOGE("Failed to set state_change event handler to client info !\n");
                goto err;
        }
 
-       if (wakeup_cb != client_manager_set_client_wakeup_cb_handle(mc, (void *)wakeup_cb))
+       if (!client_manager_set_client_wakeup_cb_handle(mc, (void *)wakeup_cb))
        {
                LOGE("Failed to set wakeup event handler to client info !\n");
                goto err;
        }
 
-       if (key_cb != client_manager_set_client_key_cb_handle(mc, (void *)key_cb))
+       if (!client_manager_set_client_key_cb_handle(mc, (void *)key_cb))
        {
                LOGE("Failed to set key event handler to client info !\n");
                goto err;
        }
 
-       if (gesture_cb != client_manager_set_client_gesture_cb_handle(mc, (void *)gesture_cb))
+       if (!client_manager_set_client_gesture_cb_handle(mc, (void *)gesture_cb))
        {
                LOGE("Failed to set gesture event handler to client info !\n");
                goto err;
        }
 
-       if (voice_cb != client_manager_set_client_voice_cb_handle(mc, (void *)voice_cb))
+       if (!client_manager_set_client_voice_cb_handle(mc, (void *)voice_cb))
        {
                LOGE("Failed to set voice event handler to client info !\n");
                goto err;
        }
 
-       if (action_cb != client_manager_set_client_action_cb_handle(mc, (void *)action_cb))
+       if (!client_manager_set_client_action_cb_handle(mc, (void *)action_cb))
        {
                LOGE("Failed to set action event handler to client info !\n");
                goto err;
        }
 
-       if (feedback_cb != client_manager_set_client_feedback_cb_handle(mc, (void *)feedback_cb))
+       if (!client_manager_set_client_feedback_cb_handle(mc, (void *)feedback_cb))
        {
                LOGE("Failed to set feedback event handler to client info !\n");
                goto err;