soundwire: sysfs: Constify static struct attribute_group
authorRikard Falkeborn <rikard.falkeborn@gmail.com>
Sun, 17 Jan 2021 22:16:22 +0000 (23:16 +0100)
committerVinod Koul <vkoul@kernel.org>
Tue, 19 Jan 2021 14:51:20 +0000 (20:21 +0530)
The only place sdw_slave_dev_attr_group is used is when its address is
passed to devm_device_add_group() which takes a pointer to const struct
attribute_group. Make it const to allow the compiler to put it in
read-only memory. This makes all attribute_group structs in the file
const. Done with the help of Coccinelle.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Link: https://lore.kernel.org/r/20210117221622.34315-1-rikard.falkeborn@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/sysfs_slave.c

index b48b6617a3964115d41aa871b40097c446e83ff3..3210359cd94428d1eb1ebfc251a05af6216ebc3d 100644 (file)
@@ -130,7 +130,7 @@ static struct attribute *slave_dev_attrs[] = {
  * we don't use ATTRIBUTES_GROUP here since we want to add a subdirectory
  * for device-level properties
  */
-static struct attribute_group sdw_slave_dev_attr_group = {
+static const struct attribute_group sdw_slave_dev_attr_group = {
        .attrs  = slave_dev_attrs,
        .name = "dev-properties",
 };