arcnet: Remove unnecessary OOM messages
authorJoe Perches <joe@perches.com>
Tue, 5 May 2015 17:05:58 +0000 (10:05 -0700)
committerMichael Grzeschik <m.grzeschik@pengutronix.de>
Wed, 23 Sep 2015 06:44:24 +0000 (08:44 +0200)
Alloc failures have generic stack dumps so these are redundant.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
drivers/net/arcnet/arc-rawmode.c
drivers/net/arcnet/capmode.c
drivers/net/arcnet/com20020-pci.c
drivers/net/arcnet/rfc1051.c
drivers/net/arcnet/rfc1201.c

index e4a2702..7fc5b04 100644 (file)
@@ -98,7 +98,6 @@ static void rx(struct net_device *dev, int bufnum,
 
        skb = alloc_skb(length + ARC_HDR_SIZE, GFP_ATOMIC);
        if (skb == NULL) {
-               arc_printk(D_NORMAL, dev, "Memory squeeze, dropping packet\n");
                dev->stats.rx_dropped++;
                return;
        }
index 92b553e..de80d9e 100644 (file)
@@ -57,7 +57,6 @@ static void rx(struct net_device *dev, int bufnum,
 
        skb = alloc_skb(length + ARC_HDR_SIZE + sizeof(int), GFP_ATOMIC);
        if (skb == NULL) {
-               arc_printk(D_NORMAL, dev, "Memory squeeze, dropping packet\n");
                dev->stats.rx_dropped++;
                return;
        }
@@ -197,10 +196,8 @@ static int ack_tx(struct net_device *dev, int acked)
 
        /* Now alloc a skb to send back up through the layers: */
        ackskb = alloc_skb(length + ARC_HDR_SIZE, GFP_ATOMIC);
-       if (ackskb == NULL) {
-               arc_printk(D_NORMAL, dev, "Memory squeeze, can't acknowledge\n");
+       if (ackskb == NULL)
                goto free_outskb;
-       }
 
        skb_put(ackskb, length + ARC_HDR_SIZE);
        ackskb->dev = dev;
index 7247add..fc6809b 100644 (file)
@@ -142,10 +142,8 @@ static int com20020pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
 
                card = devm_kzalloc(&pdev->dev, sizeof(struct com20020_dev),
                                    GFP_KERNEL);
-               if (!card) {
-                       pr_err("%s out of memory!\n", __func__);
+               if (!card)
                        return -ENOMEM;
-               }
 
                card->index = i;
                card->pci_priv = priv;
index d5a0f90..7e7eda5 100644 (file)
@@ -134,7 +134,6 @@ static void rx(struct net_device *dev, int bufnum,
 
        skb = alloc_skb(length + ARC_HDR_SIZE, GFP_ATOMIC);
        if (skb == NULL) {
-               arc_printk(D_NORMAL, dev, "Memory squeeze, dropping packet\n");
                dev->stats.rx_dropped++;
                return;
        }
index 3dae141..9040a8b 100644 (file)
@@ -179,7 +179,6 @@ static void rx(struct net_device *dev, int bufnum,
 
                skb = alloc_skb(length + ARC_HDR_SIZE, GFP_ATOMIC);
                if (skb == NULL) {
-                       arc_printk(D_NORMAL, dev, "Memory squeeze, dropping packet\n");
                        dev->stats.rx_dropped++;
                        return;
                }