tools/power turbostat: Cleanup CC3-skip code
authorLen Brown <len.brown@intel.com>
Tue, 19 Mar 2019 21:52:32 +0000 (17:52 -0400)
committerLen Brown <len.brown@intel.com>
Thu, 21 Mar 2019 02:55:43 +0000 (22:55 -0400)
no functional change

Signed-off-by: Len Brown <len.brown@intel.com>
tools/power/x86/turbostat/turbostat.c

index 78d88b7d4e98033b61f33d8993be2478163e03a9..861cb795679b7c535c8b6128245b067b197e76a2 100644 (file)
@@ -666,7 +666,7 @@ void print_header(char *delim)
 
        if (DO_BIC(BIC_CPU_c1))
                outp += sprintf(outp, "%sCPU%%c1", (printed++ ? delim : ""));
-       if (DO_BIC(BIC_CPU_c3) && !do_slm_cstates && !do_knl_cstates && !do_cnl_cstates)
+       if (DO_BIC(BIC_CPU_c3))
                outp += sprintf(outp, "%sCPU%%c3", (printed++ ? delim : ""));
        if (DO_BIC(BIC_CPU_c6))
                outp += sprintf(outp, "%sCPU%%c6", (printed++ ? delim : ""));
@@ -1002,7 +1002,7 @@ int format_counters(struct thread_data *t, struct core_data *c,
        if (!(t->flags & CPU_IS_FIRST_THREAD_IN_CORE))
                goto done;
 
-       if (DO_BIC(BIC_CPU_c3) && !do_slm_cstates && !do_knl_cstates && !do_cnl_cstates)
+       if (DO_BIC(BIC_CPU_c3))
                outp += sprintf(outp, "%s%.2f", (printed++ ? delim : ""), 100.0 * c->c3/tsc);
        if (DO_BIC(BIC_CPU_c6))
                outp += sprintf(outp, "%s%.2f", (printed++ ? delim : ""), 100.0 * c->c6/tsc);
@@ -1817,7 +1817,7 @@ retry:
        if (!(t->flags & CPU_IS_FIRST_THREAD_IN_CORE))
                goto done;
 
-       if (DO_BIC(BIC_CPU_c3) && !do_slm_cstates && !do_knl_cstates && !do_cnl_cstates) {
+       if (DO_BIC(BIC_CPU_c3)) {
                if (get_msr(cpu, MSR_CORE_C3_RESIDENCY, &c->c3))
                        return -6;
        }
@@ -4703,6 +4703,9 @@ void process_cpuid()
        do_knl_cstates  = is_knl(family, model);
        do_cnl_cstates = is_cnl(family, model);
 
+       if (do_slm_cstates || do_knl_cstates || do_cnl_cstates)
+               BIC_NOT_PRESENT(BIC_CPU_c3);
+
        if (!quiet)
                decode_misc_pwr_mgmt_msr();