Revert "Use wl_signal_emit_mutable()" 52/297052/1 accepted/tizen/unified/20230814.121011
authorSeunghun Lee <shiin.lee@samsung.com>
Wed, 9 Aug 2023 10:29:40 +0000 (19:29 +0900)
committerTizen Window System <tizen.windowsystem@gmail.com>
Wed, 9 Aug 2023 11:26:11 +0000 (20:26 +0900)
The call to wl_signal_emit_mutable() causes some memory issue for some
reason, so this reverts commit 499af4f07e8119645f5df18a4d62d02b700935c3.

Change-Id: I624c94042f6e11699c41403b04e738a33163988d

src/bin/e_comp_wl.c
src/bin/e_comp_wl_buffer.c
src/bin/e_comp_wl_data.c
src/bin/e_comp_wl_input.c
src/bin/e_comp_wl_rsm.c
src/bin/e_comp_wl_tbm.c
src/bin/e_compositor.c
src/bin/e_foreign_shell.c
src/bin/e_hwc_window_queue.c

index 0bfe203b4f1fdf7936bb7a5d810022d16dac5fa5..a2f4092598d94c3610f3db22558c8392def1155e 100644 (file)
@@ -685,7 +685,7 @@ _e_comp_wl_evas_cb_hide(void *data, Evas *evas EINA_UNUSED, Evas_Object *obj EIN
    if (ec->comp_data->sub.below_obj)
      evas_object_hide(ec->comp_data->sub.below_obj);
 
-   wl_signal_emit_mutable(&e_comp_wl->ptr_constraints.surface_unmap_signal, ec);
+   wl_signal_emit(&e_comp_wl->ptr_constraints.surface_unmap_signal, ec);
 }
 
 static void
@@ -1256,7 +1256,7 @@ _e_comp_wl_evas_cb_mouse_in(void *data, Evas *evas EINA_UNUSED, Evas_Object *obj
         ec->pointer_enter_sent = EINA_TRUE;
      }
 
-   wl_signal_emit_mutable(&e_comp_wl->ptr_constraints.surface_mousein_signal, ec);
+   wl_signal_emit(&e_comp_wl->ptr_constraints.surface_mousein_signal, ec);
 }
 
 static void
@@ -2796,7 +2796,7 @@ _e_comp_wl_surface_state_commit(E_Client *ec, E_Comp_Wl_Surface_State *state)
      }
 
    /* emit a apply_viewport signal when the information of viewport and buffer is ready */
-   wl_signal_emit_mutable(&cdata->apply_viewport_signal, &cdata->surface);
+   wl_signal_emit(&cdata->apply_viewport_signal, &cdata->surface);
 
    _e_comp_wl_surface_state_buffer_set(state, NULL);
 
@@ -3123,7 +3123,7 @@ _e_comp_wl_surface_state_commit(E_Client *ec, E_Comp_Wl_Surface_State *state)
 
    state->buffer_viewport.changed = 0;
 
-   wl_signal_emit_mutable(&cdata->state_commit_signal, &cdata->surface);
+   wl_signal_emit(&cdata->state_commit_signal, &cdata->surface);
 
    if (buffer &&
        ec->exp_iconify.buffer_flush &&
index 3745b8bbde5b57090bab066e964fd2534a5f5fab..2f13888b9dc23026156c37e16ec95879c4ab2a9e 100644 (file)
@@ -327,7 +327,7 @@ _e_comp_wl_buffer_finish(E_Comp_Wl_Buffer *base)
    if (base->buffer_release)
      e_explicit_sync_buffer_release_destroy(base->buffer_release);
 
-   wl_signal_emit_mutable(&base->destroy_signal, base);
+   wl_signal_emit(&base->destroy_signal, base);
 }
 
 static E_Buffer *
index 0a1720b1dd2aeba28e11d3615e0d129687d99002..bcc19032394a90749f6bfe225df354105e519722 100644 (file)
@@ -362,7 +362,7 @@ _e_comp_wl_data_source_cb_resource_destroy(struct wl_resource *resource)
    if (!(source = wl_resource_get_user_data(resource)))
      return;
 
-   wl_signal_emit_mutable(&source->destroy_signal, source);
+   wl_signal_emit(&source->destroy_signal, source);
 
    if (e_comp_wl->drag_source == source)
      {
@@ -481,7 +481,7 @@ _e_comp_wl_data_device_destroy_selection_data_source(struct wl_listener *listene
            wl_data_device_send_selection(data_only, NULL);
      }
 
-   wl_signal_emit_mutable(&e_comp_wl->selection.signal, e_comp->wl_comp_data);
+   wl_signal_emit(&e_comp_wl->selection.signal, e_comp->wl_comp_data);
 }
 
 static struct wl_resource*
@@ -553,7 +553,7 @@ _e_comp_wl_data_device_selection_set(void *data EINA_UNUSED, E_Comp_Wl_Data_Sour
          * when it completes to optimize the entry, it should be checked more.
          */
         if (e_comp_wl->clipboard.source)
-          wl_signal_emit_mutable(&e_comp_wl->selection.signal, e_comp->wl_comp_data);
+          wl_signal_emit(&e_comp_wl->selection.signal, e_comp->wl_comp_data);
 
         return;
      }
@@ -642,7 +642,7 @@ _e_comp_wl_data_device_selection_set(void *data EINA_UNUSED, E_Comp_Wl_Data_Sour
           }
      }
 
-   wl_signal_emit_mutable(&e_comp_wl->selection.signal, e_comp->wl_comp_data);
+   wl_signal_emit(&e_comp_wl->selection.signal, e_comp->wl_comp_data);
 
    if (source)
      {
@@ -1338,7 +1338,7 @@ e_comp_wl_clipboard_source_unref(E_Comp_Wl_Clipboard_Source *source)
 
    _mime_types_free(&source->data_source);
 
-   wl_signal_emit_mutable(&source->data_source.destroy_signal, &source->data_source);
+   wl_signal_emit(&source->data_source.destroy_signal, &source->data_source);
    wl_array_release(&source->contents);
    free(source);
 
@@ -1421,7 +1421,7 @@ _e_comp_wl_manual_source_unref(E_Comp_Wl_Manual_Data_Source *source)
 
    _mime_types_free(&source->data_source);
 
-   wl_signal_emit_mutable(&source->data_source.destroy_signal, &source->data_source);
+   wl_signal_emit(&source->data_source.destroy_signal, &source->data_source);
    wl_array_release(&source->contents);
    free(source);
 
@@ -1516,7 +1516,7 @@ _e_comp_wl_data_device_manual_selection_set(E_Comp_Wl_Data_Source *source, uint3
      }
 
    //do not notify to internal clipboard
-   //wl_signal_emit_mutable(&e_comp_wl->selection.signal, e_comp->wl_comp_data);
+   //wl_signal_emit(&e_comp_wl->selection.signal, e_comp->wl_comp_data);
 
    if (source)
      {
index 0fb0a318730a9ef5530ac48488ebe6552e7c780a..cb9de49a146a4d008cc9dd580c5fa0152fdbc55b 100644 (file)
@@ -236,7 +236,7 @@ _e_comp_wl_input_cb_pointer_unbind(struct wl_resource *resource)
    e_comp_wl->ptr.resources =
      eina_list_remove(e_comp_wl->ptr.resources, resource);
 
-   wl_signal_emit_mutable(&e_comp_wl->ptr_constraints.pointer_destroy_signal, resource);
+   wl_signal_emit(&e_comp_wl->ptr_constraints.pointer_destroy_signal, resource);
 }
 
 static void
@@ -1164,7 +1164,7 @@ _e_comp_wl_input_cb_bind_pointer_constraints(struct wl_client *client, void *dat
 static void
 _e_comp_wl_input_cb_surface_commit(void *data EINA_UNUSED, E_Client *ec)
 {
-   wl_signal_emit_mutable(&e_comp_wl->ptr_constraints.surface_commit_signal, ec);
+   wl_signal_emit(&e_comp_wl->ptr_constraints.surface_commit_signal, ec);
 }
 
 static void
index ea56e99aedcbe3cc94326d4d83388935b6acd2be..1ae81b8d5d0670f9c41f0da3c86f76af5f3db276 100644 (file)
@@ -3046,7 +3046,7 @@ _e_comp_wl_remote_surface_state_commit(E_Client *ec, E_Comp_Wl_Surface_State *st
 
    state->buffer_viewport.changed = 0;
 
-   wl_signal_emit_mutable(&cdata->state_commit_signal, &cdata->surface);
+   wl_signal_emit(&cdata->state_commit_signal, &cdata->surface);
 
    /* send remote buffer to remote surfaces */
    buffer = e_pixmap_resource_get(ec->pixmap);
index 0fbb811af68f985e46303bc4b844883741aba5de..08546af11af43666d4d2dd78b6dcace326804ab1 100644 (file)
@@ -206,7 +206,7 @@ e_comp_wl_tbm_buffer_destroy(E_Comp_Wl_Buffer *buffer)
         buffer->tbm_surface = NULL;
      }
 
-   wl_signal_emit_mutable(&buffer->destroy_signal, buffer);
+   wl_signal_emit(&buffer->destroy_signal, buffer);
    free(buffer);
 }
 
index 15ab7dc7620b98e3ccbfae8d511060b8e70adf5e..9de1d1019da6a15aedfb5ab9fe0d629345524c78 100644 (file)
@@ -466,7 +466,7 @@ _e_surface_destroy(E_Surface *surface)
    if (surface->base.sub.watcher)
      wl_resource_destroy(surface->base.sub.watcher);
 
-   wl_signal_emit_mutable(&surface->base.destroy_signal, &surface->base.surface);
+   wl_signal_emit(&surface->base.destroy_signal, &surface->base.surface);
 
    e_comp_wl_surface_state_finish(&surface->base.pending);
 
index 26072c7d95990173478ebe2cc74b1ddbf5907f8c..b2ce07343b9f6b25828ab160ec6d57bc5ac55e3e 100644 (file)
@@ -433,7 +433,7 @@ _e_exported_shell_destroy(E_Exported_Shell *es)
    eina_hash_del_by_key(_exported_shell_hash,
                         e_foreign_handle_string_get(es->handle));
 
-   wl_signal_emit_mutable(&es->destroy_signal, es);
+   wl_signal_emit(&es->destroy_signal, es);
 
    _e_exported_shell_visible_set(es, EINA_FALSE);
    _e_exported_shell_ec_unlink(es);
index 9c02347f64bad15d69f5a007e2cab7e47a5155f4..bdb937cdf5a8d6752fb465fd893b77775af21584 100644 (file)
@@ -350,7 +350,7 @@ _e_hwc_window_queue_buffer_destroy(E_Hwc_Window_Queue_Buffer *queue_buffer)
              (queue_buffer->queue ? queue_buffer->queue->tqueue : NULL),
              queue_buffer->tsurface);
 
-   wl_signal_emit_mutable(&queue_buffer->destroy_signal, queue_buffer);
+   wl_signal_emit(&queue_buffer->destroy_signal, queue_buffer);
 
    E_FREE(queue_buffer);
 }
@@ -719,7 +719,7 @@ _e_hwc_window_queue_destroy(E_Hwc_Window_Queue *queue)
    EINA_LIST_FREE(queue->buffers, queue_buffer)
      _e_hwc_window_queue_buffer_destroy(queue_buffer);
 
-   wl_signal_emit_mutable(&queue->destroy_signal, queue);
+   wl_signal_emit(&queue->destroy_signal, queue);
 
    queue->tqueue = NULL;